leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IB/core: Change roce_rescan_device to return void

Browse Source 
It always returns 0. Change return type to void.

Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Daniel Jurgens
2018-01-04 17:25:33 +02:00
committed by Jason Gunthorpe
parent 8737f818ca
commit 908d6460b3
3 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/infiniband/core/cache.c
View File

@@ -821,12 +821,7 @@ static int gid_table_setup_one(struct ib_device *ib_dev)
if (err) if (err)
return err; return err;
err = roce_rescan_device(ib_dev); roce_rescan_device(ib_dev);
if (err) {
gid_table_cleanup_one(ib_dev);
gid_table_release_one(ib_dev);
}
return err; return err;
} }

2
drivers/infiniband/core/core_priv.h
View File

@@ -137,7 +137,7 @@ int ib_cache_gid_del_all_netdev_gids(struct ib_device *ib_dev, u8 port,
int roce_gid_mgmt_init(void); int roce_gid_mgmt_init(void);
void roce_gid_mgmt_cleanup(void); void roce_gid_mgmt_cleanup(void);
int roce_rescan_device(struct ib_device *ib_dev); void roce_rescan_device(struct ib_device *ib_dev);
unsigned long roce_gid_type_mask_support(struct ib_device *ib_dev, u8 port); unsigned long roce_gid_type_mask_support(struct ib_device *ib_dev, u8 port);
int ib_cache_setup_one(struct ib_device *device); int ib_cache_setup_one(struct ib_device *device);

4
drivers/infiniband/core/roce_gid_mgmt.c
View File

@@ -412,12 +412,10 @@ static void enum_all_gids_of_dev_cb(struct ib_device *ib_dev,
/* This function will rescan all of the network devices in the system /* This function will rescan all of the network devices in the system
* and add their gids, as needed, to the relevant RoCE devices. */ * and add their gids, as needed, to the relevant RoCE devices. */
int roce_rescan_device(struct ib_device *ib_dev) void roce_rescan_device(struct ib_device *ib_dev)
{ {
ib_enum_roce_netdev(ib_dev, pass_all_filter, NULL, ib_enum_roce_netdev(ib_dev, pass_all_filter, NULL,
enum_all_gids_of_dev_cb, NULL); enum_all_gids_of_dev_cb, NULL);
return 0;
} }
static void callback_for_addr_gid_device_scan(struct ib_device *device, static void callback_for_addr_gid_device_scan(struct ib_device *device,