leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/msm: Stop dropping struct_mutex in recover_worker()

Browse Source 
Now that we don't have the mmap_sem lock inversion, we don't need to
jump through this particular hoop anymore.

Signed-off-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
This commit is contained in:
Kristian H. Kristensen
2019-03-20 10:09:09 -07:00
committed by Rob Clark
parent 48e7f18392
commit 8ea274accd
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/gpu/drm/msm/msm_gpu.c
View File

@@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work)
task = get_pid_task(submit->pid, PIDTYPE_PID); task = get_pid_task(submit->pid, PIDTYPE_PID);
if (task) { if (task) {
comm = kstrdup(task->comm, GFP_KERNEL); comm = kstrdup(task->comm, GFP_KERNEL);
/*
* So slightly annoying, in other paths like
* mmap'ing gem buffers, mmap_sem is acquired
* before struct_mutex, which means we can't
* hold struct_mutex across the call to
* get_cmdline(). But submits are retired
* from the same in-order workqueue, so we can
* safely drop the lock here without worrying
* about the submit going away.
*/
mutex_unlock(&dev->struct_mutex);
cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL); cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
put_task_struct(task); put_task_struct(task);
mutex_lock(&dev->struct_mutex);
} }
if (comm && cmd) { if (comm && cmd) {