leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc: Mark archrandom.h functions __must_check

Browse Source 
We must not use the pointer output without validating the
success of the random read.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20200110145422.49141-10-broonie@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Richard Henderson
2020-01-10 14:54:21 +00:00
committed by Theodore Ts'o
parent 98dcfce697
commit 8dae77ac56
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
arch/powerpc/include/asm/archrandom.h
View File

@@ -6,17 +6,17 @@
#include <asm/machdep.h> #include <asm/machdep.h>
static inline bool arch_get_random_long(unsigned long *v) static inline bool __must_check arch_get_random_long(unsigned long *v)
{ {
return false; return false;
} }
static inline bool arch_get_random_int(unsigned int *v) static inline bool __must_check arch_get_random_int(unsigned int *v)
{ {
return false; return false;
} }
static inline bool arch_get_random_seed_long(unsigned long *v) static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
{ {
if (ppc_md.get_random_seed) if (ppc_md.get_random_seed)
return ppc_md.get_random_seed(v); return ppc_md.get_random_seed(v);
@@ -24,7 +24,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v)
return false; return false;
} }
static inline bool arch_get_random_seed_int(unsigned int *v) static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
{ {
unsigned long val; unsigned long val;
bool rc; bool rc;