leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fold mount_pseudo_xattr() into pseudo_fs_get_tree()

Browse Source 
... now that all other callers are gone

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2019-05-11 11:43:59 -04:00
parent 389e22fb46
commit 8d9e46d807
2 changed files with 34 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
fs/libfs.c
View File

@@ -240,16 +240,43 @@ static const struct super_operations simple_super_operations = {
static int pseudo_fs_get_tree(struct fs_context *fc) static int pseudo_fs_get_tree(struct fs_context *fc)
{ {
struct pseudo_fs_context *ctx = fc->fs_private; struct pseudo_fs_context *ctx = fc->fs_private;
struct dentry *root; struct super_block *s;
struct inode *root;
root = mount_pseudo_xattr(fc->fs_type, s = sget_userns(fc->fs_type, NULL, set_anon_super, SB_KERNMOUNT|SB_NOUSER,
ctx->ops, ctx->xattr, &init_user_ns, NULL);
ctx->dops, ctx->magic); if (IS_ERR(s))
if (IS_ERR(root)) return PTR_ERR(s);
return PTR_ERR(root);
fc->root = root; s->s_maxbytes = MAX_LFS_FILESIZE;
s->s_blocksize = PAGE_SIZE;
s->s_blocksize_bits = PAGE_SHIFT;
s->s_magic = ctx->magic;
s->s_op = ctx->ops ?: &simple_super_operations;
s->s_xattr = ctx->xattr;
s->s_time_gran = 1;
root = new_inode(s);
if (!root)
goto Enomem;
/*
* since this is the first inode, make it number 1. New inodes created
* after this must take care not to collide with it (by passing
* max_reserved of 1 to iunique).
*/
root->i_ino = 1;
root->i_mode = S_IFDIR | S_IRUSR | S_IWUSR;
root->i_atime = root->i_mtime = root->i_ctime = current_time(root);
s->s_root = d_make_root(root);
if (!s->s_root)
goto Enomem;
s->s_d_op = ctx->dops;
s->s_flags |= SB_ACTIVE;
fc->root = dget(s->s_root);
return 0; return 0;
Enomem:
deactivate_locked_super(s);
return -ENOMEM;
} }
static void pseudo_fs_free(struct fs_context *fc) static void pseudo_fs_free(struct fs_context *fc)
@@ -281,53 +308,6 @@ struct pseudo_fs_context *init_pseudo(struct fs_context *fc,
} }
EXPORT_SYMBOL(init_pseudo); EXPORT_SYMBOL(init_pseudo);
/*
* Common helper for pseudo-filesystems (sockfs, pipefs, bdev - stuff that
* will never be mountable)
*/
struct dentry *mount_pseudo_xattr(struct file_system_type *fs_type,
const struct super_operations *ops, const struct xattr_handler **xattr,
const struct dentry_operations *dops, unsigned long magic)
{
struct super_block *s;
struct inode *root;
s = sget_userns(fs_type, NULL, set_anon_super, SB_KERNMOUNT|SB_NOUSER,
&init_user_ns, NULL);
if (IS_ERR(s))
return ERR_CAST(s);
s->s_maxbytes = MAX_LFS_FILESIZE;
s->s_blocksize = PAGE_SIZE;
s->s_blocksize_bits = PAGE_SHIFT;
s->s_magic = magic;
s->s_op = ops ? ops : &simple_super_operations;
s->s_xattr = xattr;
s->s_time_gran = 1;
root = new_inode(s);
if (!root)
goto Enomem;
/*
* since this is the first inode, make it number 1. New inodes created
* after this must take care not to collide with it (by passing
* max_reserved of 1 to iunique).
*/
root->i_ino = 1;
root->i_mode = S_IFDIR | S_IRUSR | S_IWUSR;
root->i_atime = root->i_mtime = root->i_ctime = current_time(root);
s->s_root = d_make_root(root);
if (!s->s_root)
goto Enomem;
s->s_d_op = dops;
s->s_flags |= SB_ACTIVE;
return dget(s->s_root);
Enomem:
deactivate_locked_super(s);
return ERR_PTR(-ENOMEM);
}
EXPORT_SYMBOL(mount_pseudo_xattr);
int simple_open(struct inode *inode, struct file *file) int simple_open(struct inode *inode, struct file *file)
{ {
if (inode->i_private) if (inode->i_private)

13
include/linux/fs.h
View File

@@ -2254,19 +2254,6 @@ struct super_block *sget(struct file_system_type *type,
int (*test)(struct super_block *,void *), int (*test)(struct super_block *,void *),
int (*set)(struct super_block *,void *), int (*set)(struct super_block *,void *),
int flags, void *data); int flags, void *data);
extern struct dentry *mount_pseudo_xattr(struct file_system_type *,
const struct super_operations *ops,
const struct xattr_handler **xattr,
const struct dentry_operations *dops,
unsigned long);
static inline struct dentry *
mount_pseudo(struct file_system_type *fs_type,
const struct super_operations *ops,
const struct dentry_operations *dops, unsigned long magic)
{
return mount_pseudo_xattr(fs_type, ops, NULL, dops, magic);
}
/* Alas, no aliases. Too much hassle with bringing module.h everywhere */ /* Alas, no aliases. Too much hassle with bringing module.h everywhere */
#define fops_get(fops) \ #define fops_get(fops) \