leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: aacraid: Use memdup_user() as a cleanup

Browse Source 
Fix coccicheck warning which recommends to use memdup_user().

This patch fixes the following coccicheck warning:

drivers/scsi/aacraid/commctrl.c:516:15-22: WARNING opportunity for memdup_user

Link: https://lore.kernel.org/r/1587868964-75969-1-git-send-email-zou_wei@huawei.com
Fixes: 4645df1035 ("[PATCH] aacraid: swapped kmalloc args.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Zou Wei 2020-04-26 10:42:44 +08:00 committed by Martin K. Petersen
parent 29022b6130
commit 8d925b1f00
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/scsi/aacraid/commctrl.c
View File

@ -513,15 +513,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
goto cleanup; goto cleanup;
} }
user_srbcmd = kmalloc(fibsize, GFP_KERNEL); user_srbcmd = memdup_user(user_srb, fibsize);
if (!user_srbcmd) { if (IS_ERR(user_srbcmd)) {
dprintk((KERN_DEBUG"aacraid: Could not make a copy of the srb\n")); rcode = PTR_ERR(user_srbcmd);
rcode = -ENOMEM;
goto cleanup;
}
if(copy_from_user(user_srbcmd, user_srb,fibsize)){
dprintk((KERN_DEBUG"aacraid: Could not copy srb from user\n"));
rcode = -EFAULT;
goto cleanup; goto cleanup;
} }