leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: host: Use fallthrough pseudo-keyword

Browse Source 
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200707195023.GA3792@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gustavo A. R. Silva
2020-07-07 14:50:23 -05:00
committed by Greg Kroah-Hartman
parent e288fc9828
commit 8b84724e9e
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/host/ehci-dbg.c
View File

@@ -823,7 +823,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
break; break;
case 0: /* illegal reserved capability */ case 0: /* illegal reserved capability */
cap = 0; cap = 0;
/* FALLTHROUGH */ fallthrough;
default: /* unknown */ default: /* unknown */
break; break;
} }

4
drivers/usb/host/ehci-fsl.c
View File

@@ -234,7 +234,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
break; break;
case FSL_USB2_PHY_UTMI_WIDE: case FSL_USB2_PHY_UTMI_WIDE:
portsc |= PORT_PTS_PTW; portsc |= PORT_PTS_PTW;
/* fall through */ fallthrough;
case FSL_USB2_PHY_UTMI: case FSL_USB2_PHY_UTMI:
/* Presence of this node "has_fsl_erratum_a006918" /* Presence of this node "has_fsl_erratum_a006918"
* in device-tree is used to stop USB controller * in device-tree is used to stop USB controller
@@ -244,7 +244,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
dev_warn(dev, "USB PHY clock invalid\n"); dev_warn(dev, "USB PHY clock invalid\n");
return -EINVAL; return -EINVAL;
} }
/* fall through */ fallthrough;
case FSL_USB2_PHY_UTMI_DUAL: case FSL_USB2_PHY_UTMI_DUAL:
/* PHY_CLK_VALID bit is de-featured from all controller /* PHY_CLK_VALID bit is de-featured from all controller
* versions below 2.4 and is to be checked only for * versions below 2.4 and is to be checked only for

4
drivers/usb/host/ehci-hcd.c
View File

@@ -982,7 +982,7 @@ rescan:
start_unlink_async(ehci, qh); start_unlink_async(ehci, qh);
else else
start_unlink_intr(ehci, qh); start_unlink_intr(ehci, qh);
/* FALL THROUGH */ fallthrough;
case QH_STATE_COMPLETING: /* already in unlinking */ case QH_STATE_COMPLETING: /* already in unlinking */
case QH_STATE_UNLINK: /* wait for hw to finish? */ case QH_STATE_UNLINK: /* wait for hw to finish? */
case QH_STATE_UNLINK_WAIT: case QH_STATE_UNLINK_WAIT:
@@ -999,7 +999,7 @@ idle_timeout:
qh_destroy(ehci, qh); qh_destroy(ehci, qh);
break; break;
} }
/* fall through */ fallthrough;
default: default:
/* caller was supposed to have unlinked any requests; /* caller was supposed to have unlinked any requests;
* that's not our job. just leak this memory. * that's not our job. just leak this memory.

2
drivers/usb/host/ehci-q.c
View File

@@ -874,7 +874,7 @@ qh_make (
switch (urb->dev->speed) { switch (urb->dev->speed) {
case USB_SPEED_LOW: case USB_SPEED_LOW:
info1 |= QH_LOW_SPEED; info1 |= QH_LOW_SPEED;
/* FALL THROUGH */ fallthrough;
case USB_SPEED_FULL: case USB_SPEED_FULL:
/* EPS 0 means "full" */ /* EPS 0 means "full" */

2
drivers/usb/host/ehci-sched.c
View File

@@ -2475,7 +2475,7 @@ restart:
ehci_dbg(ehci, "corrupt type %d frame %d shadow %p\n", ehci_dbg(ehci, "corrupt type %d frame %d shadow %p\n",
type, frame, q.ptr); type, frame, q.ptr);
/* BUG(); */ /* BUG(); */
/* FALL THROUGH */ fallthrough;
case Q_TYPE_QH: case Q_TYPE_QH:
case Q_TYPE_FSTN: case Q_TYPE_FSTN:
/* End of the iTDs and siTDs */ /* End of the iTDs and siTDs */