leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] pr_debug: check pr_debug() arguments

Browse Source 
check pr_debug() arguments

When DEBUG isn't defined pr_debug() is defined away as an empty macro.  By
throwing away the arguments we allow completely incorrect code to build.

Instead let's make it an empty inline which checks arguments and mark it so gcc
can check the format specification.

This results in a seemingly insignificant code size increase.  A x86-64
allyesconfig:

   text    data     bss     dec     hex filename
25354768        7191098 4854720 37400586        23ab00a vmlinux.before
25354945        7191138 4854720 37400803        23ab0e3 vmlinux

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Zach Brown 2006-10-03 01:16:15 -07:00 committed by Linus Torvalds
parent 3879b6b6a8
commit 8b2a1fd1b3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/kernel.h
View File

@ -216,8 +216,10 @@ extern void dump_stack(void);
#define pr_debug(fmt,arg...) \ #define pr_debug(fmt,arg...) \
printk(KERN_DEBUG fmt,##arg) printk(KERN_DEBUG fmt,##arg)
#else #else
#define pr_debug(fmt,arg...) \ static inline int __attribute__ ((format (printf, 1, 2))) pr_debug(const char * fmt, ...)
do { } while (0) {
return 0;
}
#endif #endif
#define pr_info(fmt,arg...) \ #define pr_info(fmt,arg...) \