leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serial: core: Fix handling of options after MMIO address

Browse Source 
Guenter Roeck reported a regression caused by commit "serial: earlycon:
Extend earlycon command line option to support 64-bit addresses":

console= and earlycon= options have the following format:
...,<addr>,<options>

Historically used here simple_strtoul() had no problems with comma, but the
new and recommended kstrtoull() requires null-terminated string and returns
-EINVAL in case there are "options" at the end. There is no recommended to
use function currently that will support it, so stick to obsolete
simple_strtoull() variant.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alexander Sverdlin 2016-09-12 13:29:29 +02:00 committed by Greg Kroah-Hartman
parent 1e512d4533
commit 8b2303de39
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/tty/serial/serial_core.c
View File

@ -1892,14 +1892,11 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
* console=<name>,0x<addr>,<options> * console=<name>,0x<addr>,<options>
* is also accepted; the returned @iotype will be UPIO_MEM. * is also accepted; the returned @iotype will be UPIO_MEM.
* *
* Returns 0 on success, -EINVAL or -ERANGE on failure * Returns 0 on success or -EINVAL on failure
*/ */
int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr, int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
char **options) char **options)
{ {
int ret;
unsigned long long tmp;
if (strncmp(p, "mmio,", 5) == 0) { if (strncmp(p, "mmio,", 5) == 0) {
*iotype = UPIO_MEM; *iotype = UPIO_MEM;
p += 5; p += 5;
@ -1925,10 +1922,11 @@ int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
return -EINVAL; return -EINVAL;
} }
ret = kstrtoull(p, 0, &tmp); /*
if (ret) * Before you replace it with kstrtoull(), think about options separator
return ret; * (',') it will not tolerate
*addr = tmp; */
*addr = simple_strtoull(p, NULL, 0);
p = strchr(p, ','); p = strchr(p, ',');
if (p) if (p)
p++; p++;