leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

via-velocity: do not use PCI resources before pci_enable_device()

Browse Source 
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.

The semantic match that finds this problem is as follows:

// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@

(
* x->irq
|
* x->resource
|
* request(x, ...)
)
 ...
*pci_enable_device(x)
// </smpl>

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kulikov Vasiliy 2010-08-03 05:43:18 +00:00 committed by David S. Miller
parent 7a0c2029d6
commit 889635fd6b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/via-velocity.c
View File

@ -2763,12 +2763,12 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi
vptr->dev = dev;
dev->irq = pdev->irq;
ret = pci_enable_device(pdev);
if (ret < 0)
goto err_free_dev;
dev->irq = pdev->irq;
ret = velocity_get_pci_info(vptr, pdev);
if (ret < 0) {
/* error message already printed */