leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ALSA] intel8x0 - Fix Oops at kdump crash kernel

Browse Source 
Fixed Oops at crash kernel from intel8x0 driver that is triggered
from interrupt handler.  Proper irqsave version seems needed for
kexec/kdump.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
This commit is contained in:
Takashi Iwai 2007-03-13 21:52:36 +01:00 committed by Jaroslav Kysela
parent 0a07acafd6
commit 883be79367
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/pci/intel8x0.c
View File

@ -725,10 +725,11 @@ static void fill_nocache(void *buf, int size, int nocache)
static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ichdev) static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ichdev)
{ {
unsigned long port = ichdev->reg_offset; unsigned long port = ichdev->reg_offset;
unsigned long flags;
int status, civ, i, step; int status, civ, i, step;
int ack = 0; int ack = 0;
spin_lock(&chip->reg_lock); spin_lock_irqsave(&chip->reg_lock, flags);
status = igetbyte(chip, port + ichdev->roff_sr); status = igetbyte(chip, port + ichdev->roff_sr);
civ = igetbyte(chip, port + ICH_REG_OFF_CIV); civ = igetbyte(chip, port + ICH_REG_OFF_CIV);
if (!(status & ICH_BCIS)) { if (!(status & ICH_BCIS)) {
@ -768,7 +769,7 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich
ack = 1; ack = 1;
} }
} }
spin_unlock(&chip->reg_lock); spin_unlock_irqrestore(&chip->reg_lock, flags);
if (ack && ichdev->substream) { if (ack && ichdev->substream) {
snd_pcm_period_elapsed(ichdev->substream); snd_pcm_period_elapsed(ichdev->substream);
} }