leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/char/ppdev.c: use kasprintf

Browse Source 
kasprintf combines kmalloc and sprintf, and takes care of the size
calculation itself.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression a,flag;
expression list args;
statement S;
@@

  a =
-  \(kmalloc\|kzalloc\)(...,flag)
+  kasprintf(flag,args)
  <... when != a
  if (a == NULL || ...) S
  ...>
- sprintf(a,args);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Julia Lawall 2010-05-26 14:43:55 -07:00 committed by Linus Torvalds
parent 56d611a04f
commit 87575437d8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/ppdev.c
View File

@ -287,12 +287,10 @@ static int register_device (int minor, struct pp_struct *pp)
char *name; char *name;
int fl; int fl;
name = kmalloc (strlen (CHRDEV) + 3, GFP_KERNEL); name = kasprintf(GFP_KERNEL, CHRDEV "%x", minor);
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
sprintf (name, CHRDEV "%x", minor);
port = parport_find_number (minor); port = parport_find_number (minor);
if (!port) { if (!port) {
printk (KERN_WARNING "%s: no associated port!\n", name); printk (KERN_WARNING "%s: no associated port!\n", name);