leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qlge: Fix memory leak in the process of refill

Browse Source 
Driver was leaking memory when page allocation failures occurs.

Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jitendra Kalsaria 2012-02-03 14:06:51 +00:00 committed by David S. Miller
parent 19257f5a1a
commit 81f25d96f1
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/qlogic/qlge/qlge_main.c
View File

@ -1143,14 +1143,16 @@ static void ql_update_lbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
int i; int i;
while (rx_ring->lbq_free_cnt > 32) { while (rx_ring->lbq_free_cnt > 32) {
for (i = 0; i < 16; i++) { for (i = (rx_ring->lbq_clean_idx % 16); i < 16; i++) {
netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev,
"lbq: try cleaning clean_idx = %d.\n", "lbq: try cleaning clean_idx = %d.\n",
clean_idx); clean_idx);
lbq_desc = &rx_ring->lbq[clean_idx]; lbq_desc = &rx_ring->lbq[clean_idx];
if (ql_get_next_chunk(qdev, rx_ring, lbq_desc)) { if (ql_get_next_chunk(qdev, rx_ring, lbq_desc)) {
rx_ring->lbq_clean_idx = clean_idx;
netif_err(qdev, ifup, qdev->ndev, netif_err(qdev, ifup, qdev->ndev,
"Could not get a page chunk.\n"); "Could not get a page chunk, i=%d, clean_idx =%d .\n",
i, clean_idx);
return; return;
} }
@ -1195,7 +1197,7 @@ static void ql_update_sbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
int i; int i;
while (rx_ring->sbq_free_cnt > 16) { while (rx_ring->sbq_free_cnt > 16) {
for (i = 0; i < 16; i++) { for (i = (rx_ring->sbq_clean_idx % 16); i < 16; i++) {
sbq_desc = &rx_ring->sbq[clean_idx]; sbq_desc = &rx_ring->sbq[clean_idx];
netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev,
"sbq: try cleaning clean_idx = %d.\n", "sbq: try cleaning clean_idx = %d.\n",