leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

USB: serial: metro-usb: remove unneeded cast and function call

Browse Source 
We should use kzalloc() instead of kmalloc() and memset(), and remove an
unneeded void * cast as well.

Cc: Aleksey Babahin <tamerlan311@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2012-03-08 14:00:11 -08:00
parent dd63b0b4d6
commit 8111e4ecf9
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/usb/serial/metro-usb.c
View File

@ -58,7 +58,7 @@ static bool debug;
static void metrousb_read_int_callback(struct urb *urb) static void metrousb_read_int_callback(struct urb *urb)
{ {
struct usb_serial_port *port = (struct usb_serial_port *)urb->context; struct usb_serial_port *port = urb->context;
struct metrousb_private *metro_priv = usb_get_serial_port_data(port); struct metrousb_private *metro_priv = usb_get_serial_port_data(port);
struct tty_struct *tty; struct tty_struct *tty;
unsigned char *data = urb->transfer_buffer; unsigned char *data = urb->transfer_buffer;
@ -253,13 +253,10 @@ static int metrousb_startup(struct usb_serial *serial)
port = serial->port[i]; port = serial->port[i];
/* Declare memory. */ /* Declare memory. */
metro_priv = kmalloc(sizeof(struct metrousb_private), GFP_KERNEL); metro_priv = kzalloc(sizeof(struct metrousb_private), GFP_KERNEL);
if (!metro_priv) if (!metro_priv)
return -ENOMEM; return -ENOMEM;
/* Clear memory. */
memset(metro_priv, 0x00, sizeof(struct metrousb_private));
/* Initialize memory. */ /* Initialize memory. */
spin_lock_init(&metro_priv->lock); spin_lock_init(&metro_priv->lock);
usb_set_serial_port_data(port, metro_priv); usb_set_serial_port_data(port, metro_priv);