leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCI/VPD: Don't check Large Resource Item Names for validity

Browse Source 
VPD consists of a series of Small and Large Resources.  Computing the size
of VPD requires only the length of each, which is specified in the generic
tag of each resource.  We only expect to see ID_STRING, RO_DATA, and
RW_DATA in VPD, but it's not a problem if it contains other resource types
because all we care about is the size.

Drop the validity checking of Large Resource items.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
This commit is contained in:
Bjorn Helgaas
2021-07-15 16:59:58 -05:00
parent 6303049d16
commit 7fa75dd8c6
1 changed files with 8 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/pci/vpd.c
View File

@@ -83,13 +83,7 @@ static size_t pci_vpd_size(struct pci_dev *dev, size_t old_size)
if (header[0] & PCI_VPD_LRDT) { if (header[0] & PCI_VPD_LRDT) {
/* Large Resource Data Type Tag */ /* Large Resource Data Type Tag */
tag = pci_vpd_lrdt_tag(header); if (pci_read_vpd(dev, off + 1, 2, &header[1]) != 2) {
/* Only read length from known tag items */
if ((tag == PCI_VPD_LTIN_ID_STRING) ||
(tag == PCI_VPD_LTIN_RO_DATA) ||
(tag == PCI_VPD_LTIN_RW_DATA)) {
if (pci_read_vpd(dev, off+1, 2,
&header[1]) != 2) {
pci_warn(dev, "failed VPD read at offset %zu\n", pci_warn(dev, "failed VPD read at offset %zu\n",
off + 1); off + 1);
return 0; return 0;
@@ -99,11 +93,6 @@ static size_t pci_vpd_size(struct pci_dev *dev, size_t old_size)
goto error; goto error;
off += PCI_VPD_LRDT_TAG_SIZE + size; off += PCI_VPD_LRDT_TAG_SIZE + size;
} else {
pci_warn(dev, "invalid large VPD tag %02x at offset %zu\n",
tag, off);
return 0;
}
} else { } else {
/* Short Resource Data Type Tag */ /* Short Resource Data Type Tag */
tag = pci_vpd_srdt_tag(header); tag = pci_vpd_srdt_tag(header);