leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sctp: remove an unnecessary check from sctp_endpoint_destroy

Browse Source 
ep->base.sk gets it's value since sctp_endpoint_new, nowhere
will change it. So there's no need to check if it's null, as
it can never be null.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xin Long 2017-06-29 17:28:06 +08:00 committed by David S. Miller
parent 0b58e6db0f
commit 7f304b9efa
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
net/sctp/endpointola.c
View File

@ -268,16 +268,14 @@ static void sctp_endpoint_destroy(struct sctp_endpoint *ep)
memset(ep->secret_key, 0, sizeof(ep->secret_key)); memset(ep->secret_key, 0, sizeof(ep->secret_key));
/* Give up our hold on the sock. */
sk = ep->base.sk; sk = ep->base.sk;
if (sk != NULL) { /* Remove and free the port */
/* Remove and free the port */ if (sctp_sk(sk)->bind_hash)
if (sctp_sk(sk)->bind_hash) sctp_put_port(sk);
sctp_put_port(sk);
sctp_sk(sk)->ep = NULL; sctp_sk(sk)->ep = NULL;
sock_put(sk); /* Give up our hold on the sock */
} sock_put(sk);
kfree(ep); kfree(ep);
SCTP_DBG_OBJCNT_DEC(ep); SCTP_DBG_OBJCNT_DEC(ep);