leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sm501fb: fix timing limits

Browse Source 
Vertical sync height register can only hold 6 bits.  Fix the hsync start test
to use > instead of >=.  Also add a few clarifying comments.

Signed-off-by: Ville Syrjala <syrjala@sci.fi>
Acked-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Ville Syrjala 2008-03-04 14:28:49 -08:00 committed by Linus Torvalds
parent 19d06eff4e
commit 7e533705bd
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/video/sm501fb.c
View File

@ -237,12 +237,14 @@ static int sm501fb_check_var(struct fb_var_screeninfo *var,
/* check we can fit these values into the registers */ /* check we can fit these values into the registers */
if (var->hsync_len > 255 || var->vsync_len > 255) if (var->hsync_len > 255 || var->vsync_len > 63)
return -EINVAL; return -EINVAL;
if ((var->xres + var->right_margin) >= 4096) /* hdisplay end and hsync start */
if ((var->xres + var->right_margin) > 4096)
return -EINVAL; return -EINVAL;
/* vdisplay end and vsync start */
if ((var->yres + var->lower_margin) > 2048) if ((var->yres + var->lower_margin) > 2048)
return -EINVAL; return -EINVAL;