leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: move snd_powermac's probe function to .devinit.text

Browse Source 
A pointer to snd_pmac_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (when having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Rene Herman <rene.herman@keyaccess.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Uwe Kleine-König 2009-03-28 00:27:10 +01:00 committed by Takashi Iwai
parent 0221c81b1b
commit 7d2ac1036b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/ppc/powermac.c
View File

@ -51,7 +51,7 @@ static struct platform_device *device;
/* /*
*/ */
static int __init snd_pmac_probe(struct platform_device *devptr) static int __devinit snd_pmac_probe(struct platform_device *devptr)
{ {
struct snd_card *card; struct snd_card *card;
struct snd_pmac *chip; struct snd_pmac *chip;