leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iommu: Fix reference count leak in iommu_group_alloc.

Browse Source 
kobject_init_and_add() takes reference even when it fails.
Thus, when kobject_init_and_add() returns an error,
kobject_put() must be called to properly clean up the kobject.

Fixes: d72e31c937 ("iommu: IOMMU Groups")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200527210020.6522-1-wu000273@umn.edu
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Qiushi Wu 2020-05-27 16:00:19 -05:00 committed by Joerg Roedel
parent ed3119e455
commit 7cc3161373
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iommu/iommu.c
View File

@ -510,7 +510,7 @@ struct iommu_group *iommu_group_alloc(void)
NULL, "%d", group->id); NULL, "%d", group->id);
if (ret) { if (ret) {
ida_simple_remove(&iommu_group_ida, group->id); ida_simple_remove(&iommu_group_ida, group->id);
kfree(group); kobject_put(&group->kobj);
return ERR_PTR(ret); return ERR_PTR(ret);
} }