leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ceph: fix ceph_set_acl()

Browse Source 
If acl is equivalent to file mode permission bits, ceph_set_acl()
needs to remove any existing acl xattr. Use __ceph_setxattr() to
handle both setting and removing acl xattr cases, it doesn't return
-ENODATA when there is no acl xattr.

Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
This commit is contained in:
Yan, Zheng 2014-02-11 13:08:51 +08:00 committed by Sage Weil
parent 524186ace6
commit 7a92d64760
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/ceph/acl.c
View File

@ -160,11 +160,7 @@ int ceph_set_acl(struct inode *inode, struct posix_acl *acl, int type)
goto out_dput; goto out_dput;
} }
if (value) ret = __ceph_setxattr(dentry, name, value, size, 0);
ret = __ceph_setxattr(dentry, name, value, size, 0);
else
ret = __ceph_removexattr(dentry, name);
if (ret) { if (ret) {
if (new_mode != old_mode) { if (new_mode != old_mode) {
newattrs.ia_mode = old_mode; newattrs.ia_mode = old_mode;