leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

driver core: auxiliary bus: Fix auxiliary bus shutdown null auxdrv ptr

Browse Source 
If the probe of the auxdrv failed, the device->driver is set to NULL.
During kernel shutdown, the bus shutdown will call auxdrv->shutdown and
cause an invalid ptr dereference. Add check to make sure device->driver is
not NULL before we proceed.

Fixes: 7de3697e9c ("Add auxiliary bus support")
Cc: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/r/160710040926.1889434.8840329810698403478.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dave Jiang
2020-12-04 09:46:49 -07:00
committed by Greg Kroah-Hartman
parent 5812b32e01
commit 784b2c48ac
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/base/auxiliary.c
View File

@@ -92,10 +92,15 @@ static int auxiliary_bus_remove(struct device *dev)
static void auxiliary_bus_shutdown(struct device *dev) static void auxiliary_bus_shutdown(struct device *dev)
{ {
struct auxiliary_driver *auxdrv = to_auxiliary_drv(dev->driver); struct auxiliary_driver *auxdrv = NULL;
struct auxiliary_device *auxdev = to_auxiliary_dev(dev); struct auxiliary_device *auxdev;
if (auxdrv->shutdown) if (dev->driver) {
auxdrv = to_auxiliary_drv(dev->driver);
auxdev = to_auxiliary_dev(dev);
}
if (auxdrv && auxdrv->shutdown)
auxdrv->shutdown(auxdev); auxdrv->shutdown(auxdev);
} }