leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] usb/cpia2_core: clean up a min_t() cast

Browse Source 
It makes sense to make the min_t() cast unsigned here since we don't
really want negative sizes.  Making it signed causes a static checker
warning in Smatch.  Smatch knows "fw->size - i" is positive but it
doesn't know that fw->size is less than INT_MAX so in theory casting it
to int might lead to a negative.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Dan Carpenter 2016-02-09 09:14:12 -02:00 committed by Mauro Carvalho Chehab
parent bb07df8ae1
commit 76880b4015
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/usb/cpia2/cpia2_core.c
View File

@ -923,7 +923,7 @@ static int apply_vp_patch(struct camera_data *cam)
/* ... followed by the data payload */ /* ... followed by the data payload */
for (i = 2; i < fw->size; i += 64) { for (i = 2; i < fw->size; i += 64) {
cmd.start = 0x0C; /* Data */ cmd.start = 0x0C; /* Data */
cmd.reg_count = min_t(int, 64, fw->size - i); cmd.reg_count = min_t(uint, 64, fw->size - i);
memcpy(cmd.buffer.block_data, &fw->data[i], cmd.reg_count); memcpy(cmd.buffer.block_data, &fw->data[i], cmd.reg_count);
cpia2_send_command(cam, &cmd); cpia2_send_command(cam, &cmd);
} }