leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: qualcomm: rmnet: Remove redundant command check

Browse Source 
The command packet size is already checked once in
rmnet_map_deaggregate() for the header, packet and trailer size, so
this additional check is not needed.

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Subash Abhinov Kasiviswanathan
2018-05-15 18:52:02 -06:00
committed by David S. Miller
parent bbde32d38b
commit 721ce0f644
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
View File

@@ -69,17 +69,9 @@ static void rmnet_map_send_ack(struct sk_buff *skb,
struct rmnet_map_control_command *cmd; struct rmnet_map_control_command *cmd;
int xmit_status; int xmit_status;
if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4) { if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4)
if (skb->len < sizeof(struct rmnet_map_header) + skb_trim(skb,
RMNET_MAP_GET_LENGTH(skb) + skb->len - sizeof(struct rmnet_map_dl_csum_trailer));
sizeof(struct rmnet_map_dl_csum_trailer)) {
kfree_skb(skb);
return;
}
skb_trim(skb, skb->len -
sizeof(struct rmnet_map_dl_csum_trailer));
}
skb->protocol = htons(ETH_P_MAP); skb->protocol = htons(ETH_P_MAP);