leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] mn88473: One function call less in mn88473_init() after error

Browse Source 
The release_firmware() function was called by the mn88473_init() function even
if a previous function call "request_firmware" failed.
This implementation detail could be improved by the introduction of another
jump label.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2014-12-01 19:15:20 -03:00 committed by Mauro Carvalho Chehab
parent b59113845f
commit 71947828ca
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/media/mn88473/mn88473.c
View File

@ -225,7 +225,7 @@ static int mn88473_init(struct dvb_frontend *fe)
ret = request_firmware(&fw, fw_file, &client->dev); ret = request_firmware(&fw, fw_file, &client->dev);
if (ret) { if (ret) {
dev_err(&client->dev, "firmare file '%s' not found\n", fw_file); dev_err(&client->dev, "firmare file '%s' not found\n", fw_file);
goto err; goto err_request_firmware;
} }
dev_info(&client->dev, "downloading firmware from file '%s'\n", dev_info(&client->dev, "downloading firmware from file '%s'\n",
@ -261,9 +261,10 @@ static int mn88473_init(struct dvb_frontend *fe)
dev->warm = true; dev->warm = true;
return 0; return 0;
err: err:
release_firmware(fw); release_firmware(fw);
err_request_firmware:
dev_dbg(&client->dev, "failed=%d\n", ret); dev_dbg(&client->dev, "failed=%d\n", ret);
return ret; return ret;
} }