leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm

Browse Source 
There is no point in having two distinct entries, merge them and
rename the symbol for more clarity: MTD_NAND_ECC_SW_BCH

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
Miquel Raynal 2019-02-06 15:12:27 +01:00
parent e90a619fb7
commit 714c068228
10 changed files with 14 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/configs/omap2plus_defconfig
View File

@ -144,7 +144,7 @@ CONFIG_MTD_ONENAND=y
CONFIG_MTD_ONENAND_VERIFY_WRITE=y CONFIG_MTD_ONENAND_VERIFY_WRITE=y
CONFIG_MTD_ONENAND_OMAP2=y CONFIG_MTD_ONENAND_OMAP2=y
CONFIG_MTD_NAND=y CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_ECC_BCH=y CONFIG_MTD_NAND_ECC_SW_BCH=y
CONFIG_MTD_NAND_OMAP2=y CONFIG_MTD_NAND_OMAP2=y
CONFIG_MTD_NAND_OMAP_BCH=y CONFIG_MTD_NAND_OMAP_BCH=y
CONFIG_MTD_SPI_NOR=m CONFIG_MTD_SPI_NOR=m

2
arch/arm/configs/pxa_defconfig
View File

@ -186,7 +186,7 @@ CONFIG_MTD_M25P80=m
CONFIG_MTD_BLOCK2MTD=y CONFIG_MTD_BLOCK2MTD=y
CONFIG_MTD_DOCG3=m CONFIG_MTD_DOCG3=m
CONFIG_MTD_NAND=m CONFIG_MTD_NAND=m
CONFIG_MTD_NAND_ECC_BCH=y CONFIG_MTD_NAND_ECC_SW_BCH=y
CONFIG_MTD_NAND_GPIO=m CONFIG_MTD_NAND_GPIO=m
CONFIG_MTD_NAND_DISKONCHIP=m CONFIG_MTD_NAND_DISKONCHIP=m
CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADVANCED=y CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADVANCED=y

2
arch/mips/configs/db1xxx_defconfig
View File

@ -96,7 +96,7 @@ CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_M25P80=y CONFIG_MTD_M25P80=y
CONFIG_MTD_SST25L=y CONFIG_MTD_SST25L=y
CONFIG_MTD_NAND=y CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_ECC_BCH=y CONFIG_MTD_NAND_ECC_SW_BCH=y
CONFIG_MTD_NAND_AU1550=y CONFIG_MTD_NAND_AU1550=y
CONFIG_MTD_NAND_PLATFORM=y CONFIG_MTD_NAND_PLATFORM=y
CONFIG_MTD_SPI_NOR=y CONFIG_MTD_SPI_NOR=y

2
arch/mips/configs/generic/board-ni169445.config
View File

@ -16,7 +16,7 @@ CONFIG_MTD_BLOCK=y
CONFIG_MTD_CMDLINE_PARTS=y CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_NAND_ECC=y CONFIG_MTD_NAND_ECC=y
CONFIG_MTD_NAND_ECC_BCH=y CONFIG_MTD_NAND_ECC_SW_BCH=y
CONFIG_MTD_NAND=y CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_GPIO=y CONFIG_MTD_NAND_GPIO=y
CONFIG_MTD_NAND_IDS=y CONFIG_MTD_NAND_IDS=y

2
drivers/mtd/devices/Kconfig
View File

@ -207,7 +207,7 @@ comment "Disk-On-Chip Device Drivers"
config MTD_DOCG3 config MTD_DOCG3
tristate "M-Systems Disk-On-Chip G3" tristate "M-Systems Disk-On-Chip G3"
select BCH select BCH
select BCH_CONST_PARAMS if !MTD_NAND_BCH select BCH_CONST_PARAMS if !MTD_NAND_ECC_SW_BCH
select BITREVERSE select BITREVERSE
help help
This provides an MTD device driver for the M-Systems DiskOnChip This provides an MTD device driver for the M-Systems DiskOnChip

9
drivers/mtd/nand/raw/Kconfig
View File

@ -22,14 +22,9 @@ menuconfig MTD_NAND
if MTD_NAND if MTD_NAND
config MTD_NAND_BCH config MTD_NAND_ECC_SW_BCH
tristate tristate "Support software BCH ECC"
select BCH select BCH
depends on MTD_NAND_ECC_BCH
default MTD_NAND
config MTD_NAND_ECC_BCH
bool "Support software BCH ECC"
default n default n
help help
This enables support for software BCH error correction. Binary BCH This enables support for software BCH error correction. Binary BCH

2
drivers/mtd/nand/raw/Makefile
View File

@ -2,7 +2,7 @@
obj-$(CONFIG_MTD_NAND) += nand.o obj-$(CONFIG_MTD_NAND) += nand.o
obj-$(CONFIG_MTD_NAND_ECC) += nand_ecc.o obj-$(CONFIG_MTD_NAND_ECC) += nand_ecc.o
obj-$(CONFIG_MTD_NAND_BCH) += nand_bch.o obj-$(CONFIG_MTD_NAND_ECC_SW_BCH) += nand_bch.o
obj-$(CONFIG_MTD_SM_COMMON) += sm_common.o obj-$(CONFIG_MTD_SM_COMMON) += sm_common.o
obj-$(CONFIG_MTD_NAND_CAFE) += cafe_nand.o obj-$(CONFIG_MTD_NAND_CAFE) += cafe_nand.o

2
drivers/mtd/nand/raw/nand_base.c
View File

@ -5087,7 +5087,7 @@ static int nand_set_ecc_soft_ops(struct nand_chip *chip)
return 0; return 0;
case NAND_ECC_BCH: case NAND_ECC_BCH:
if (!mtd_nand_has_bch()) { if (!mtd_nand_has_bch()) {
WARN(1, "CONFIG_MTD_NAND_ECC_BCH not enabled\n"); WARN(1, "CONFIG_MTD_NAND_ECC_SW_BCH not enabled\n");
return -EINVAL; return -EINVAL;
} }
ecc->calculate = nand_bch_calculate_ecc; ecc->calculate = nand_bch_calculate_ecc;

4
drivers/mtd/nand/raw/omap2.c
View File

@ -1725,9 +1725,9 @@ static bool omap2_nand_ecc_check(struct omap_nand_info *info)
break; break;
} }
if (ecc_needs_bch && !IS_ENABLED(CONFIG_MTD_NAND_ECC_BCH)) { if (ecc_needs_bch && !IS_ENABLED(CONFIG_MTD_NAND_ECC_SW_BCH)) {
dev_err(&info->pdev->dev, dev_err(&info->pdev->dev,
"CONFIG_MTD_NAND_ECC_BCH not enabled\n"); "CONFIG_MTD_NAND_ECC_SW_BCH not enabled\n");
return false; return false;
} }
if (ecc_needs_omap_bch && !IS_ENABLED(CONFIG_MTD_NAND_OMAP_BCH)) { if (ecc_needs_omap_bch && !IS_ENABLED(CONFIG_MTD_NAND_OMAP_BCH)) {

6
include/linux/mtd/nand_bch.h
View File

@ -15,7 +15,7 @@ struct mtd_info;
struct nand_chip; struct nand_chip;
struct nand_bch_control; struct nand_bch_control;
#if defined(CONFIG_MTD_NAND_ECC_BCH) #if IS_ENABLED(CONFIG_MTD_NAND_ECC_SW_BCH)
static inline int mtd_nand_has_bch(void) { return 1; } static inline int mtd_nand_has_bch(void) { return 1; }
@ -39,7 +39,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd);
*/ */
void nand_bch_free(struct nand_bch_control *nbc); void nand_bch_free(struct nand_bch_control *nbc);
#else /* !CONFIG_MTD_NAND_ECC_BCH */ #else /* !CONFIG_MTD_NAND_ECC_SW_BCH */
static inline int mtd_nand_has_bch(void) { return 0; } static inline int mtd_nand_has_bch(void) { return 0; }
@ -64,6 +64,6 @@ static inline struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
static inline void nand_bch_free(struct nand_bch_control *nbc) {} static inline void nand_bch_free(struct nand_bch_control *nbc) {}
#endif /* CONFIG_MTD_NAND_ECC_BCH */ #endif /* CONFIG_MTD_NAND_ECC_SW_BCH */
#endif /* __MTD_NAND_BCH_H__ */ #endif /* __MTD_NAND_BCH_H__ */