leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[IA64] ia32_signal.c: erroneous use of memset/memcpy

Browse Source 
Found by Alexander Nyberg, improved by Bjorn Helgaas.

- Fix the incorrect argument to sizeof()
- looks like memcpy() code pass was dervived from code that used
  copy_from_user().  But in this case we are doing to kernel space
  to kernel space copy, so memcpy is the right routine, but it
  doesn't return an error code.
 
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
This commit is contained in:
Arun Sharma 2005-04-22 13:06:47 -07:00 committed by Tony Luck
parent efab7739d9
commit 7130667107
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/ia64/ia32/ia32_signal.c
View File

@ -460,10 +460,9 @@ __ia32_rt_sigsuspend (compat_sigset_t *sset, unsigned int sigsetsize, struct sig
sigset_t oldset, set; sigset_t oldset, set;
scr->scratch_unat = 0; /* avoid leaking kernel bits to user level */ scr->scratch_unat = 0; /* avoid leaking kernel bits to user level */
memset(&set, 0, sizeof(&set)); memset(&set, 0, sizeof(set));
if (memcpy(&set.sig, &sset->sig, sigsetsize)) memcpy(&set.sig, &sset->sig, sigsetsize);
return -EFAULT;
sigdelsetmask(&set, ~_BLOCKABLE); sigdelsetmask(&set, ~_BLOCKABLE);