leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ceph: Mark the file cache as unreclaimable

Browse Source 
Ceph creates multiple caches with the SLAB_RECLAIMABLE flag set, so
that it can satisfy its internal needs. Inspecting the code shows that
most of the caches are indeed reclaimable since they are directly
related to the generic inode/dentry shrinkers. However, one of the
cache used to satisfy struct file is not reclaimable since its
entries are freed only when the last reference to the file is
dropped. If a heavily loaded node opens a lot of files it can
introduce non-trivial discrepancies between memory shown as reclaimable
and what is actually reclaimed when drop_caches is used.

Fix this by removing the reclaimable flag for the file's cache.

Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>
This commit is contained in:
Nikolay Borisov 2016-07-25 20:12:13 +03:00 committed by Ilya Dryomov
parent c8799fc467
commit 6b1a9a6c54
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ceph/super.c
View File

@ -686,8 +686,8 @@ static int __init init_caches(void)
if (ceph_dentry_cachep == NULL) if (ceph_dentry_cachep == NULL)
goto bad_dentry; goto bad_dentry;
ceph_file_cachep = KMEM_CACHE(ceph_file_info, ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD);
SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD);
if (ceph_file_cachep == NULL) if (ceph_file_cachep == NULL)
goto bad_file; goto bad_file;