leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core_param() for genuinely core kernel parameters

Browse Source 
There are a lot of one-liner uses of __setup() in the kernel: they're
cumbersome and not queryable (definitely not settable) via /sys.  Yet
it's ugly to simplify them to module_param(), because by default that
inserts a prefix of the module name (usually filename).

So, introduce a "core_param".  The parameter gets no prefix, but
appears in /sys/module/kernel/parameters/ (if non-zero perms arg).  I
thought about using the name "core", but that's more common than
"kernel".  And if you create a module called "kernel", you will die
a horrible death.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2008-10-22 10:00:23 -05:00
parent 9b473de872
commit 67e67ceaac
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kernel/params.c
View File

@@ -637,14 +637,14 @@ static void __init param_sysfs_builtin(void)
dot = strchr(kp->name, '.');
if (!dot) {
DEBUGP("couldn't find period in first %d characters "
"of %s\n", MODULE_NAME_LEN, kp->name);
continue;
/* This happens for core_param() */
strcpy(modname, "kernel");
name_len = 0;
} else {
name_len = dot - kp->name + 1;
strlcpy(modname, kp->name, name_len);
}
name_len = dot - kp->name;
strncpy(modname, kp->name, name_len);
modname[name_len] = '\0';
kernel_add_sysfs_param(modname, kp, name_len+1);
kernel_add_sysfs_param(modname, kp, name_len);
}
}