leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwmon: (tmp421) Add of_node_put() before return

Browse Source 
Fix following coccicheck warning:
./drivers/hwmon/tmp421.c:416:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return.

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211018121538.16482-1-wanjiabing@vivo.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Wan Jiabing 2021-10-18 08:15:37 -04:00 committed by Guenter Roeck
parent efb389b8c3
commit 66ae4d562b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/tmp421.c
View File

@ -418,8 +418,10 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
continue;
err = tmp421_probe_child_from_dt(client, child, data);
if (err)
if (err) {
of_node_put(child);
return err;
}
}
return 0;