leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ieee802154: fix one possible memleak in adf7242_probe

Browse Source 
When probe fail, we should destroy the workqueue.

Fixes: 2795e8c251 ("net: ieee802154: fix a potential NULL pointer dereference")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20200717090121.2143-1-liujian56@huawei.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
This commit is contained in:
Liu Jian
2020-07-17 17:01:21 +08:00
committed by Stefan Schmidt
parent 473309fb83
commit 66673f96f0
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ieee802154/adf7242.c
View File

@@ -1262,7 +1262,7 @@ static int adf7242_probe(struct spi_device *spi)
WQ_MEM_RECLAIM); WQ_MEM_RECLAIM);
if (unlikely(!lp->wqueue)) { if (unlikely(!lp->wqueue)) {
ret = -ENOMEM; ret = -ENOMEM;
goto err_hw_init; goto err_alloc_wq;
} }
ret = adf7242_hw_init(lp); ret = adf7242_hw_init(lp);
@@ -1294,6 +1294,8 @@ static int adf7242_probe(struct spi_device *spi)
return ret; return ret;
err_hw_init: err_hw_init:
destroy_workqueue(lp->wqueue);
err_alloc_wq:
mutex_destroy(&lp->bmux); mutex_destroy(&lp->bmux);
ieee802154_free_hw(lp->hw); ieee802154_free_hw(lp->hw);