leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ath5k: remove _bh from inner locks

Browse Source 
spin_unlock_bh(&txq->lock) already disables softirqs so we don't want
to do it here.  Fixes smatch warnings:

   drivers/net/wireless/ath/ath5k/base.c:1048 ath5k_drain_tx_buffs() error: double lock 'bottom_half:'
   drivers/net/wireless/ath/ath5k/base.c:1056 ath5k_drain_tx_buffs() error: double unlock 'bottom_half:'

Reported-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Bob Copeland 2012-06-15 16:03:29 -04:00 committed by John W. Linville
parent 80b08a8d88
commit 6617942e15
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/ath/ath5k/base.c
View File

@ -1045,11 +1045,11 @@ ath5k_drain_tx_buffs(struct ath5k_hw *ah)
ath5k_txbuf_free_skb(ah, bf); ath5k_txbuf_free_skb(ah, bf);
spin_lock_bh(&ah->txbuflock); spin_lock(&ah->txbuflock);
list_move_tail(&bf->list, &ah->txbuf); list_move_tail(&bf->list, &ah->txbuf);
ah->txbuf_len++; ah->txbuf_len++;
txq->txq_len--; txq->txq_len--;
spin_unlock_bh(&ah->txbuflock); spin_unlock(&ah->txbuflock);
} }
txq->link = NULL; txq->link = NULL;
txq->txq_poll_mark = false; txq->txq_poll_mark = false;