leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: sd: change allow_restart to bool in sysfs interface

Browse Source 
/sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0
unexpectedly by writing an invalid string such as the following:

echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
weiping zhang 2017-10-12 14:56:44 +08:00 committed by Martin K. Petersen
parent b8018b973c
commit 658e9a6dc1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/sd.c
View File

@ -253,6 +253,7 @@ static ssize_t
allow_restart_store(struct device *dev, struct device_attribute *attr, allow_restart_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
bool v;
struct scsi_disk *sdkp = to_scsi_disk(dev); struct scsi_disk *sdkp = to_scsi_disk(dev);
struct scsi_device *sdp = sdkp->device; struct scsi_device *sdp = sdkp->device;
@ -262,7 +263,10 @@ allow_restart_store(struct device *dev, struct device_attribute *attr,
if (sdp->type != TYPE_DISK && sdp->type != TYPE_ZBC) if (sdp->type != TYPE_DISK && sdp->type != TYPE_ZBC)
return -EINVAL; return -EINVAL;
sdp->allow_restart = simple_strtoul(buf, NULL, 10); if (kstrtobool(buf, &v))
return -EINVAL;
sdp->allow_restart = v;
return count; return count;
} }