leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Phonet: remove useless locking in device cleanup

Browse Source 
Incoming packets and sockets are already gone.
The netdevice notifier is unregistered under the RTNL lock
There remains a race with the rtnetlink handlers unregistration, but it
is a generic RTNL issue that was already present before this change.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
remi.denis-courmont@nokia 2009-01-23 03:00:29 +00:00 committed by David S. Miller
parent 660f706d93
commit 6530e0fee1
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/phonet/pn_dev.c
View File

@ -204,13 +204,8 @@ void phonet_device_exit(void)
struct phonet_device *pnd, *n; struct phonet_device *pnd, *n;
rtnl_unregister_all(PF_PHONET); rtnl_unregister_all(PF_PHONET);
rtnl_lock(); unregister_netdevice_notifier(&phonet_device_notifier);
spin_lock_bh(&pndevs.lock);
list_for_each_entry_safe(pnd, n, &pndevs.list, list) list_for_each_entry_safe(pnd, n, &pndevs.list, list)
__phonet_device_free(pnd); __phonet_device_free(pnd);
spin_unlock_bh(&pndevs.lock);
rtnl_unlock();
unregister_netdevice_notifier(&phonet_device_notifier);
} }