leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ext4: Improve comments in ext4_quota_{on|off}()

Browse Source 
Improve comments in ext4_quota_{on|off}() to explain that returning
success despite ext4_journal_start() failing is deliberate.

Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Jan Kara 2017-04-24 16:49:16 +02:00
parent 5c26eac43a
commit 61a929870d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/ext4/super.c
View File

@ -5377,6 +5377,11 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
struct inode *inode = d_inode(path->dentry); struct inode *inode = d_inode(path->dentry);
handle_t *handle; handle_t *handle;
/*
* Set inode flags to prevent userspace from messing with quota
* files. If this fails, we return success anyway since quotas
* are already enabled and this is not a hard failure.
*/
inode_lock(inode); inode_lock(inode);
handle = ext4_journal_start(inode, EXT4_HT_QUOTA, 1); handle = ext4_journal_start(inode, EXT4_HT_QUOTA, 1);
if (IS_ERR(handle)) if (IS_ERR(handle))
@ -5477,8 +5482,11 @@ static int ext4_quota_off(struct super_block *sb, int type)
goto out_put; goto out_put;
inode_lock(inode); inode_lock(inode);
/* Update modification times of quota files when userspace can /*
* start looking at them */ * Update modification times of quota files when userspace can
* start looking at them. If we fail, we return success anyway since
* this is not a hard failure and quotas are already disabled.
*/
handle = ext4_journal_start(inode, EXT4_HT_QUOTA, 1); handle = ext4_journal_start(inode, EXT4_HT_QUOTA, 1);
if (IS_ERR(handle)) if (IS_ERR(handle))
goto out_unlock; goto out_unlock;