leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HID: wiimote: narrow spinlock range in wiimote_hid_event()

Browse Source 
In `wiimote_hid_event()`, the `wdata->state.lock` spinlock does not need
to be held while searching `handlers[]` for a suitable handler function.
Change it so the spinlock is only held during the call to the handler
function itself.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: David Rheinsberg <david.rheinsberg@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Ian Abbott 2020-09-04 14:21:43 +01:00 committed by Jiri Kosina
parent aeeba45a9d
commit 5eae59cc87
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hid/hid-wiimote-core.c
View File

@ -1625,12 +1625,12 @@ static int wiimote_hid_event(struct hid_device *hdev, struct hid_report *report,
if (size < 1) if (size < 1)
return -EINVAL; return -EINVAL;
spin_lock_irqsave(&wdata->state.lock, flags);
for (i = 0; handlers[i].id; ++i) { for (i = 0; handlers[i].id; ++i) {
h = &handlers[i]; h = &handlers[i];
if (h->id == raw_data[0] && h->size < size) { if (h->id == raw_data[0] && h->size < size) {
spin_lock_irqsave(&wdata->state.lock, flags);
h->func(wdata, &raw_data[1]); h->func(wdata, &raw_data[1]);
spin_unlock_irqrestore(&wdata->state.lock, flags);
break; break;
} }
} }
@ -1639,8 +1639,6 @@ static int wiimote_hid_event(struct hid_device *hdev, struct hid_report *report,
hid_warn(hdev, "Unhandled report %hhu size %d\n", raw_data[0], hid_warn(hdev, "Unhandled report %hhu size %d\n", raw_data[0],
size); size);
spin_unlock_irqrestore(&wdata->state.lock, flags);
return 0; return 0;
} }