leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libnvdimm: Convert to DEVICE_ATTR_ADMIN_RO()

Browse Source 
Move libnvdimm sysfs attributes that currently use an open coded
DEVICE_ATTR() to hide sensitive root-only information (physical memory
layout) to the new DEVICE_ATTR_ADMIN_RO() helper.

Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
This commit is contained in:
Dan Williams 2020-07-20 15:08:13 -07:00 committed by Vishal Verma
parent 60d360acdd
commit 5cf81ce189
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/nvdimm/namespace_devs.c
View File

@ -1309,7 +1309,7 @@ static ssize_t resource_show(struct device *dev,
return -ENXIO; return -ENXIO;
return sprintf(buf, "%#llx\n", (unsigned long long) res->start); return sprintf(buf, "%#llx\n", (unsigned long long) res->start);
} }
static DEVICE_ATTR(resource, 0400, resource_show, NULL); static DEVICE_ATTR_ADMIN_RO(resource);
static const unsigned long blk_lbasize_supported[] = { 512, 520, 528, static const unsigned long blk_lbasize_supported[] = { 512, 520, 528,
4096, 4104, 4160, 4224, 0 }; 4096, 4104, 4160, 4224, 0 };

2
drivers/nvdimm/pfn_devs.c
View File

@ -218,7 +218,7 @@ static ssize_t resource_show(struct device *dev,
return rc; return rc;
} }
static DEVICE_ATTR(resource, 0400, resource_show, NULL); static DEVICE_ATTR_ADMIN_RO(resource);
static ssize_t size_show(struct device *dev, static ssize_t size_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)

2
drivers/nvdimm/region_devs.c
View File

@ -605,7 +605,7 @@ static ssize_t resource_show(struct device *dev,
return sprintf(buf, "%#llx\n", nd_region->ndr_start); return sprintf(buf, "%#llx\n", nd_region->ndr_start);
} }
static DEVICE_ATTR(resource, 0400, resource_show, NULL); static DEVICE_ATTR_ADMIN_RO(resource);
static ssize_t persistence_domain_show(struct device *dev, static ssize_t persistence_domain_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)