leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

phy: error handling for platform_device_register_simple()

Browse Source 
platform_device_register_simple() returns ERR_PTR() and not NULL.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2009-04-11 01:52:29 -07:00 committed by David S. Miller
parent 3384901f1b
commit 57401d5e36
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/phy/fixed.c
View File

@ -19,6 +19,7 @@
#include <linux/mii.h> #include <linux/mii.h>
#include <linux/phy.h> #include <linux/phy.h>
#include <linux/phy_fixed.h> #include <linux/phy_fixed.h>
#include <linux/err.h>
#define MII_REGS_NUM 29 #define MII_REGS_NUM 29
@ -207,8 +208,8 @@ static int __init fixed_mdio_bus_init(void)
int ret; int ret;
pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0); pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
if (!pdev) { if (IS_ERR(pdev)) {
ret = -ENOMEM; ret = PTR_ERR(pdev);
goto err_pdev; goto err_pdev;
} }