leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: fib_notifier: propagate possible error during fib notifier registration

Browse Source 
Unlike events for registered notifier, during the registration, the
errors that happened for the block being registered are not propagated
up to the caller. Make sure the error is propagated for FIB rules and
entries.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Pirko
2019-10-03 11:49:28 +02:00
committed by David S. Miller
parent 7c550daffe
commit 55c894f762
6 changed files with 71 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
net/core/fib_rules.c
View File

@@ -354,15 +354,20 @@ int fib_rules_dump(struct net *net, struct notifier_block *nb, int family)
{
struct fib_rules_ops *ops;
struct fib_rule *rule;
int err = 0;
ops = lookup_rules_ops(net, family);
if (!ops)
return -EAFNOSUPPORT;
list_for_each_entry_rcu(rule, &ops->rules_list, list)
call_fib_rule_notifier(nb, FIB_EVENT_RULE_ADD, rule, family);
list_for_each_entry_rcu(rule, &ops->rules_list, list) {
err = call_fib_rule_notifier(nb, FIB_EVENT_RULE_ADD,
rule, family);
if (err)
break;
}
rules_ops_put(ops);
return 0;
return err;
}
EXPORT_SYMBOL_GPL(fib_rules_dump);