leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eCryptfs: Invalidate dcache entries when lower i_nlink is zero

Browse Source 
Consider eCryptfs dcache entries to be stale when the corresponding
lower inode's i_nlink count is zero. This solves a problem caused by the
lower inode being directly modified, without going through the eCryptfs
mount, leaving stale eCryptfs dentries cached and the eCryptfs inode's
i_nlink count not being cleared.

Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reported-by: Richard Weinberger <richard@nod.at>
Cc: stable@vger.kernel.org
This commit is contained in:
Tyler Hicks 2015-08-05 11:26:36 -05:00
parent 4469942bbb
commit 5556e7e6d3
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fs/ecryptfs/dentry.c
View File

@ -45,20 +45,20 @@
static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags) static int ecryptfs_d_revalidate(struct dentry *dentry, unsigned int flags)
{ {
struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry); struct dentry *lower_dentry = ecryptfs_dentry_to_lower(dentry);
int rc; int rc = 1;
if (!(lower_dentry->d_flags & DCACHE_OP_REVALIDATE))
return 1;
if (flags & LOOKUP_RCU) if (flags & LOOKUP_RCU)
return -ECHILD; return -ECHILD;
rc = lower_dentry->d_op->d_revalidate(lower_dentry, flags); if (lower_dentry->d_flags & DCACHE_OP_REVALIDATE)
if (d_really_is_positive(dentry)) { rc = lower_dentry->d_op->d_revalidate(lower_dentry, flags);
struct inode *lower_inode =
ecryptfs_inode_to_lower(d_inode(dentry));
fsstack_copy_attr_all(d_inode(dentry), lower_inode); if (d_really_is_positive(dentry)) {
struct inode *inode = d_inode(dentry);
fsstack_copy_attr_all(inode, ecryptfs_inode_to_lower(inode));
if (!inode->i_nlink)
return 0;
} }
return rc; return rc;
} }