leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clk: imx: use sign_extend32() and abs()

Browse Source 
This simplifies the given function by getting rid of the manual
sign extension as well as saving an absolute value in an extra
variable.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This commit is contained in:
Martin Kepplinger
2015-09-29 13:32:27 +02:00
committed by Stephen Boyd
parent 7a03fe6f48
commit 53fdc8fd25
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/clk/imx/clk-pllv2.c
View File

@@ -77,7 +77,7 @@ struct clk_pllv2 {
static unsigned long __clk_pllv2_recalc_rate(unsigned long parent_rate, static unsigned long __clk_pllv2_recalc_rate(unsigned long parent_rate,
u32 dp_ctl, u32 dp_op, u32 dp_mfd, u32 dp_mfn) u32 dp_ctl, u32 dp_op, u32 dp_mfd, u32 dp_mfn)
{ {
long mfi, mfn, mfd, pdf, ref_clk, mfn_abs; long mfi, mfn, mfd, pdf, ref_clk;
unsigned long dbl; unsigned long dbl;
s64 temp; s64 temp;
@@ -87,19 +87,15 @@ static unsigned long __clk_pllv2_recalc_rate(unsigned long parent_rate,
mfi = (dp_op & MXC_PLL_DP_OP_MFI_MASK) >> MXC_PLL_DP_OP_MFI_OFFSET; mfi = (dp_op & MXC_PLL_DP_OP_MFI_MASK) >> MXC_PLL_DP_OP_MFI_OFFSET;
mfi = (mfi <= 5) ? 5 : mfi; mfi = (mfi <= 5) ? 5 : mfi;
mfd = dp_mfd & MXC_PLL_DP_MFD_MASK; mfd = dp_mfd & MXC_PLL_DP_MFD_MASK;
mfn = mfn_abs = dp_mfn & MXC_PLL_DP_MFN_MASK; mfn = dp_mfn & MXC_PLL_DP_MFN_MASK;
/* Sign extend to 32-bits */ mfn = sign_extend32(mfn, 26);
if (mfn >= 0x04000000) {
mfn |= 0xFC000000;
mfn_abs = -mfn;
}
ref_clk = 2 * parent_rate; ref_clk = 2 * parent_rate;
if (dbl != 0) if (dbl != 0)
ref_clk *= 2; ref_clk *= 2;
ref_clk /= (pdf + 1); ref_clk /= (pdf + 1);
temp = (u64) ref_clk * mfn_abs; temp = (u64) ref_clk * abs(mfn);
do_div(temp, mfd + 1); do_div(temp, mfd + 1);
if (mfn < 0) if (mfn < 0)
temp = -temp; temp = -temp;