leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MIPS: RB532: Fix bit swapping in rb532_set_bit()

Browse Source 
The algorithm works unconditionally. If bitval is one, the first line is
a no op and the second line sets the bit at offset position. Vice versa,
if bitval is zero, the first line clears the bit at offset position and
the second line is a no op.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Phil Sutter 2008-11-12 00:09:30 +01:00 committed by Ralf Baechle
parent f839490ab4
commit 5379a5fdf3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/mips/rb532/gpio.c
View File

@ -119,13 +119,11 @@ static inline void rb532_set_bit(unsigned bitval,
unsigned long flags; unsigned long flags;
u32 val; u32 val;
bitval = !!bitval; /* map parameter to {0,1} */
local_irq_save(flags); local_irq_save(flags);
val = readl(ioaddr); val = readl(ioaddr);
val &= ~( ~bitval << offset ); /* unset bit if bitval == 0 */ val &= ~(!bitval << offset); /* unset bit if bitval == 0 */
val |= ( bitval << offset ); /* set bit if bitval == 1 */ val |= (!!bitval << offset); /* set bit if bitval == 1 */
writel(val, ioaddr); writel(val, ioaddr);
local_irq_restore(flags); local_irq_restore(flags);