leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/eeh: Reworked eeh_pe_bus_get()

Browse Source 
The original implementation is ugly: unnecessary if statements and
"out" tag. This reworks the function to avoid above weaknesses. No
functional changes introduced.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Gavin Shan 2016-02-09 15:50:23 +11:00 committed by Michael Ellerman
parent ee3b93ebfb
commit 4eb0799ff9
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
arch/powerpc/kernel/eeh_pe.c
View File

@ -920,25 +920,21 @@ const char *eeh_pe_loc_get(struct eeh_pe *pe)
*/ */
struct pci_bus *eeh_pe_bus_get(struct eeh_pe *pe) struct pci_bus *eeh_pe_bus_get(struct eeh_pe *pe)
{ {
struct pci_bus *bus = NULL;
struct eeh_dev *edev; struct eeh_dev *edev;
struct pci_dev *pdev; struct pci_dev *pdev;
if (pe->type & EEH_PE_PHB) { if (pe->type & EEH_PE_PHB)
bus = pe->phb->bus; return pe->phb->bus;
} else if (pe->type & EEH_PE_BUS ||
pe->type & EEH_PE_DEVICE) {
if (pe->state & EEH_PE_PRI_BUS) {
bus = pe->bus;
goto out;
}
edev = list_first_entry(&pe->edevs, struct eeh_dev, list); /* The primary bus might be cached during probe time */
pdev = eeh_dev_to_pci_dev(edev); if (pe->state & EEH_PE_PRI_BUS)
if (pdev) return pe->bus;
bus = pdev->bus;
}
out: /* Retrieve the parent PCI bus of first (top) PCI device */
return bus; edev = list_first_entry_or_null(&pe->edevs, struct eeh_dev, list);
pdev = eeh_dev_to_pci_dev(edev);
if (pdev)
return pdev->bus;
return NULL;
} }