leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: rtl8712: mlme_linux: Clean up tests if NULL returned on failure

Browse Source 
Some functions like kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:

@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Bhaktipriya Shridhar 2016-03-22 20:29:13 +05:30 committed by Greg Kroah-Hartman
parent 06884afcf2
commit 4d97b69147
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/rtl8712/mlme_linux.c
View File

@ -153,7 +153,7 @@ void r8712_report_sec_ie(struct _adapter *adapter, u8 authmode, u8 *sec_ie)
buff = NULL; buff = NULL;
if (authmode == _WPA_IE_ID_) { if (authmode == _WPA_IE_ID_) {
buff = kzalloc(IW_CUSTOM_MAX, GFP_ATOMIC); buff = kzalloc(IW_CUSTOM_MAX, GFP_ATOMIC);
if (buff == NULL) if (!buff)
return; return;
p = buff; p = buff;
p += sprintf(p, "ASSOCINFO(ReqIEs="); p += sprintf(p, "ASSOCINFO(ReqIEs=");