leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ecryptfs: re-order a condition for static checkers

Browse Source 
Static checkers complain that we are using "s->i" as an offset before
we check whether it is within bounds.  It doesn't matter much but we
can easily swap the order of the checks to make everyone happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
This commit is contained in:
Dan Carpenter 2018-08-22 13:43:59 +03:00 committed by Tyler Hicks
parent 0bdf8a8245
commit 4b47a8b51e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/ecryptfs/keystore.c
View File

@ -1063,8 +1063,9 @@ ecryptfs_parse_tag_70_packet(char **filename, size_t *filename_size,
"rc = [%d]\n", __func__, rc); "rc = [%d]\n", __func__, rc);
goto out_free_unlock; goto out_free_unlock;
} }
while (s->decrypted_filename[s->i] != '\0'
&& s->i < s->block_aligned_filename_size) while (s->i < s->block_aligned_filename_size &&
s->decrypted_filename[s->i] != '\0')
s->i++; s->i++;
if (s->i == s->block_aligned_filename_size) { if (s->i == s->block_aligned_filename_size) {
printk(KERN_WARNING "%s: Invalid tag 70 packet; could not " printk(KERN_WARNING "%s: Invalid tag 70 packet; could not "