leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] usb: au0828: remove redundant code

Browse Source 
The check for ret being non-zero is false as ret is always
zero, hence we have redundant dead code that can be removed.

Detected with CoverityScan, CID#112968 ("Constant' variable guards
dead code (DEADCODE)'")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Colin Ian King
2017-03-22 13:32:01 -03:00
committed by Mauro Carvalho Chehab
parent 1085cbf271
commit 49375e68fe
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/usb/au0828/au0828-video.c
View File

@@ -809,16 +809,9 @@ static void au0828_analog_stream_reset(struct au0828_dev *dev)
*/ */
static int au0828_stream_interrupt(struct au0828_dev *dev) static int au0828_stream_interrupt(struct au0828_dev *dev)
{ {
int ret = 0;
dev->stream_state = STREAM_INTERRUPT; dev->stream_state = STREAM_INTERRUPT;
if (test_bit(DEV_DISCONNECTED, &dev->dev_state)) if (test_bit(DEV_DISCONNECTED, &dev->dev_state))
return -ENODEV; return -ENODEV;
else if (ret) {
set_bit(DEV_MISCONFIGURED, &dev->dev_state);
dprintk(1, "%s device is misconfigured!\n", __func__);
return ret;
}
return 0; return 0;
} }