leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: aic94xx: Fix fall-through warnings for Clang

Browse Source 
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a couple of break and fallthrough statements
instead of just letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/r/9b58459045d303bbea0160f2e349f5799402a2bf.1605896059.git.gustavoars@kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Gustavo A. R. Silva
2020-11-20 12:27:24 -06:00
committed by Martin K. Petersen
parent 995ae10f80
commit 4886dd0a04
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/aic94xx/aic94xx_scb.c
View File

@@ -721,6 +721,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
fallthrough; fallthrough;
case SAS_LINK_RATE_3_0_GBPS: case SAS_LINK_RATE_3_0_GBPS:
*speed_mask |= SAS_SPEED_15_DIS; *speed_mask |= SAS_SPEED_15_DIS;
fallthrough;
default: default:
case SAS_LINK_RATE_1_5_GBPS: case SAS_LINK_RATE_1_5_GBPS:
/* nothing to do */ /* nothing to do */
@@ -739,6 +740,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
switch (pd->min_sata_lrate) { switch (pd->min_sata_lrate) {
case SAS_LINK_RATE_3_0_GBPS: case SAS_LINK_RATE_3_0_GBPS:
*speed_mask |= SATA_SPEED_15_DIS; *speed_mask |= SATA_SPEED_15_DIS;
fallthrough;
default: default:
case SAS_LINK_RATE_1_5_GBPS: case SAS_LINK_RATE_1_5_GBPS:
/* nothing to do */ /* nothing to do */

2
drivers/scsi/aic94xx/aic94xx_task.c
View File

@@ -315,6 +315,7 @@ Again:
break; break;
case SAS_PROTOCOL_SSP: case SAS_PROTOCOL_SSP:
asd_unbuild_ssp_ascb(ascb); asd_unbuild_ssp_ascb(ascb);
break;
default: default:
break; break;
} }
@@ -609,6 +610,7 @@ out_err_unmap:
break; break;
case SAS_PROTOCOL_SSP: case SAS_PROTOCOL_SSP:
asd_unbuild_ssp_ascb(a); asd_unbuild_ssp_ascb(a);
break;
default: default:
break; break;
} }