leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[IA64] MCA recovery verify pfn_valid

Browse Source 
Verify the pfn is valid before calling pfn_to_page(),
and cut isolation message if nothing was done.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Acked-by: Russ Anderson <rja@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
This commit is contained in:
Hidetoshi Seto 2005-09-20 16:34:41 +09:00 committed by Tony Luck
parent 20bb86852a
commit 4881e2cd25
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
arch/ia64/kernel/mca_drv.c
View File

@ -56,8 +56,9 @@ static struct page *page_isolate[MAX_PAGE_ISOLATE];
static int num_page_isolate = 0; static int num_page_isolate = 0;
typedef enum { typedef enum {
ISOLATE_NG = 0, ISOLATE_NG,
ISOLATE_OK = 1 ISOLATE_OK,
ISOLATE_NONE
} isolate_status_t; } isolate_status_t;
/* /*
@ -74,7 +75,7 @@ static struct {
* @paddr: poisoned memory location * @paddr: poisoned memory location
* *
* Return value: * Return value:
* ISOLATE_OK / ISOLATE_NG * one of isolate_status_t, ISOLATE_OK/NG/NONE.
*/ */
static isolate_status_t static isolate_status_t
@ -85,7 +86,10 @@ mca_page_isolate(unsigned long paddr)
/* whether physical address is valid or not */ /* whether physical address is valid or not */
if (!ia64_phys_addr_valid(paddr)) if (!ia64_phys_addr_valid(paddr))
return ISOLATE_NG; return ISOLATE_NONE;
if (!pfn_valid(paddr))
return ISOLATE_NONE;
/* convert physical address to physical page number */ /* convert physical address to physical page number */
p = pfn_to_page(paddr>>PAGE_SHIFT); p = pfn_to_page(paddr>>PAGE_SHIFT);
@ -122,10 +126,15 @@ mca_handler_bh(unsigned long paddr)
current->pid, current->comm); current->pid, current->comm);
spin_lock(&mca_bh_lock); spin_lock(&mca_bh_lock);
if (mca_page_isolate(paddr) == ISOLATE_OK) { switch (mca_page_isolate(paddr)) {
case ISOLATE_OK:
printk(KERN_DEBUG "Page isolation: ( %lx ) success.\n", paddr); printk(KERN_DEBUG "Page isolation: ( %lx ) success.\n", paddr);
} else { break;
case ISOLATE_NG:
printk(KERN_DEBUG "Page isolation: ( %lx ) failure.\n", paddr); printk(KERN_DEBUG "Page isolation: ( %lx ) failure.\n", paddr);
break;
default:
break;
} }
spin_unlock(&mca_bh_lock); spin_unlock(&mca_bh_lock);