drm: Add atomic variants of enable/disable to encoder helper funcs
This patch adds atomic_enable and atomic_disable callbacks to the encoder helpers. This will allow encoders to make informed decisions in their start-up/shutdown based on the committed state. Aside from the new hooks, this patch also introduces the new signature for .atomic_* functions going forward. Instead of passing object state (well, encoders don't have atomic state, but let's ignore that), we pass the entire atomic state so the driver can inspect more than what's happening locally. This is particularly important for the upcoming self refresh helpers. Changes in v3: - Added patch to the set Changes in v4: - Move atomic_disable above prepare (Daniel) - Add breadcrumb to .enable() docbook (Daniel) Changes in v5: - None Changes in v6: - Tweak kerneldoc some more (Sam) Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-2-sean@poorly.run Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-2-sean@poorly.run Link to v5: https://patchwork.freedesktop.org/patch/msgid/20190611160844.257498-2-sean@poorly.run Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Sam Ravnborg <sam@ravnborg.org> Tested-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190611204959.180855-1-sean@poorly.run
This commit is contained in:
@@ -1002,7 +1002,9 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state)
|
||||
|
||||
/* Right function depends upon target state. */
|
||||
if (funcs) {
|
||||
if (new_conn_state->crtc && funcs->prepare)
|
||||
if (funcs->atomic_disable)
|
||||
funcs->atomic_disable(encoder, old_state);
|
||||
else if (new_conn_state->crtc && funcs->prepare)
|
||||
funcs->prepare(encoder);
|
||||
else if (funcs->disable)
|
||||
funcs->disable(encoder);
|
||||
@@ -1311,7 +1313,9 @@ void drm_atomic_helper_commit_modeset_enables(struct drm_device *dev,
|
||||
drm_bridge_pre_enable(encoder->bridge);
|
||||
|
||||
if (funcs) {
|
||||
if (funcs->enable)
|
||||
if (funcs->atomic_enable)
|
||||
funcs->atomic_enable(encoder, old_state);
|
||||
else if (funcs->enable)
|
||||
funcs->enable(encoder);
|
||||
else if (funcs->commit)
|
||||
funcs->commit(encoder);
|
||||
|
||||
Reference in New Issue
Block a user