leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

habanalabs: return error when failing to read/write i2c

Browse Source 
The driver can't read/write from i2c if the device is in reset or
disabled. Therefore, return -EBUSY in those cases instead of 0.

This change also fixes a smatch warning about uninitialized variable.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Oded Gabbay 2019-02-26 11:23:34 +02:00 committed by Greg Kroah-Hartman
parent 8737d03720
commit 4398e7057d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/habanalabs/debugfs.c
View File

@ -25,7 +25,7 @@ static int hl_debugfs_i2c_read(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr,
int rc; int rc;
if (hl_device_disabled_or_in_reset(hdev)) if (hl_device_disabled_or_in_reset(hdev))
return 0; return -EBUSY;
memset(&pkt, 0, sizeof(pkt)); memset(&pkt, 0, sizeof(pkt));
@ -50,7 +50,7 @@ static int hl_debugfs_i2c_write(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr,
int rc; int rc;
if (hl_device_disabled_or_in_reset(hdev)) if (hl_device_disabled_or_in_reset(hdev))
return 0; return -EBUSY;
memset(&pkt, 0, sizeof(pkt)); memset(&pkt, 0, sizeof(pkt));