leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mqueue: fix mq_open() file descriptor leak on user-space processes

Browse Source 
We leak fd on lookup_one_len() failure

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
André Goddard Rosa 2010-02-23 04:04:28 -03:00 committed by Al Viro
parent 4919c5e45a
commit 4294a8eedb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ipc/mqueue.c
View File

@ -705,7 +705,7 @@ SYSCALL_DEFINE4(mq_open, const char __user *, u_name, int, oflag, mode_t, mode,
dentry = lookup_one_len(name, ipc_ns->mq_mnt->mnt_root, strlen(name)); dentry = lookup_one_len(name, ipc_ns->mq_mnt->mnt_root, strlen(name));
if (IS_ERR(dentry)) { if (IS_ERR(dentry)) {
error = PTR_ERR(dentry); error = PTR_ERR(dentry);
goto out_err; goto out_putfd;
} }
mntget(ipc_ns->mq_mnt); mntget(ipc_ns->mq_mnt);
@ -742,7 +742,6 @@ out:
mntput(ipc_ns->mq_mnt); mntput(ipc_ns->mq_mnt);
out_putfd: out_putfd:
put_unused_fd(fd); put_unused_fd(fd);
out_err:
fd = error; fd = error;
out_upsem: out_upsem:
mutex_unlock(&ipc_ns->mq_mnt->mnt_root->d_inode->i_mutex); mutex_unlock(&ipc_ns->mq_mnt->mnt_root->d_inode->i_mutex);