leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: dwc3: debugfs: fix error check

Browse Source 
debugfs APIs will return NULL if it fails
to create the file/directory we ask it to
create.

Instead of checking for IS_ERR(ptr) we must
check for !ptr.

Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Felipe Balbi
2012-01-31 13:33:32 +02:00
parent 45b3cd4ad7
commit 3d4c0d4ffb
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/usb/dwc3/debugfs.c
View File

@@ -659,8 +659,8 @@ int __devinit dwc3_debugfs_init(struct dwc3 *dwc)
int ret; int ret;
root = debugfs_create_dir(dev_name(dwc->dev), NULL); root = debugfs_create_dir(dev_name(dwc->dev), NULL);
if (IS_ERR(root)) { if (!root) {
ret = PTR_ERR(root); ret = -ENOMEM;
goto err0; goto err0;
} }
@@ -668,29 +668,29 @@ int __devinit dwc3_debugfs_init(struct dwc3 *dwc)
file = debugfs_create_file("regdump", S_IRUGO, root, dwc, file = debugfs_create_file("regdump", S_IRUGO, root, dwc,
&dwc3_regdump_fops); &dwc3_regdump_fops);
if (IS_ERR(file)) { if (!file) {
ret = PTR_ERR(file); ret = -ENOMEM;
goto err1; goto err1;
} }
file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, root, file = debugfs_create_file("mode", S_IRUGO | S_IWUSR, root,
dwc, &dwc3_mode_fops); dwc, &dwc3_mode_fops);
if (IS_ERR(file)) { if (!file) {
ret = PTR_ERR(file); ret = -ENOMEM;
goto err1; goto err1;
} }
file = debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root, file = debugfs_create_file("testmode", S_IRUGO | S_IWUSR, root,
dwc, &dwc3_testmode_fops); dwc, &dwc3_testmode_fops);
if (IS_ERR(file)) { if (!file) {
ret = PTR_ERR(file); ret = -ENOMEM;
goto err1; goto err1;
} }
file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR, root, file = debugfs_create_file("link_state", S_IRUGO | S_IWUSR, root,
dwc, &dwc3_link_state_fops); dwc, &dwc3_link_state_fops);
if (IS_ERR(file)) { if (!file) {
ret = PTR_ERR(file); ret = -ENOMEM;
goto err1; goto err1;
} }